From 87438138be253a035617ed0aaf973b3d3f9d2828 Mon Sep 17 00:00:00 2001
From: ArgonarioD <arnordorian@sina.com>
Date: Tue, 12 Jul 2022 16:31:48 +0800
Subject: [PATCH] =?UTF-8?q?=E4=BC=98=E5=8C=96=E4=BA=86Task=E6=9F=A5?=
 =?UTF-8?q?=E8=AF=A2=E4=BB=A3=E7=A0=81?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../projectmanagement/mapper/TaskMapper.java  |  2 --
 .../service/impl/ProjectGroupServiceImpl.java |  5 ++--
 .../service/impl/TaskServiceImpl.java         | 13 +++++++----
 src/main/resources/mapper/TaskMapper.xml      | 23 -------------------
 4 files changed, 11 insertions(+), 32 deletions(-)

diff --git a/src/main/java/cn/edu/hfut/rmdjzz/projectmanagement/mapper/TaskMapper.java b/src/main/java/cn/edu/hfut/rmdjzz/projectmanagement/mapper/TaskMapper.java
index d4ee807..08a2ae8 100644
--- a/src/main/java/cn/edu/hfut/rmdjzz/projectmanagement/mapper/TaskMapper.java
+++ b/src/main/java/cn/edu/hfut/rmdjzz/projectmanagement/mapper/TaskMapper.java
@@ -20,8 +20,6 @@ import java.util.List;
 public interface TaskMapper extends BaseMapper<Task> {
     List<TaskDTO> selectTaskList(@Param(Constants.WRAPPER) Wrapper<Task> wrapper);
 
-    List<TaskDTO> selectSubTaskList(@Param("projectId") Integer projectId, @Param("fatherId") Long fatherId);
-
     List<StaffProcessDTO> selectProjectProcess(@Param("projectId") Integer projectId, @Param("staffId") Integer staffId);
 
     List<TaskTrendDTO> selectClosedTaskTrendBeforeDate(@Param("projectId") Integer projectId, @Param("startDate") LocalDate startDate);
diff --git a/src/main/java/cn/edu/hfut/rmdjzz/projectmanagement/service/impl/ProjectGroupServiceImpl.java b/src/main/java/cn/edu/hfut/rmdjzz/projectmanagement/service/impl/ProjectGroupServiceImpl.java
index b474e82..0f8e546 100644
--- a/src/main/java/cn/edu/hfut/rmdjzz/projectmanagement/service/impl/ProjectGroupServiceImpl.java
+++ b/src/main/java/cn/edu/hfut/rmdjzz/projectmanagement/service/impl/ProjectGroupServiceImpl.java
@@ -93,12 +93,13 @@ public class ProjectGroupServiceImpl extends ServiceImpl<ProjectGroupMapper, Pro
     @Override
     public Boolean updateStaffPositions(String token, Integer projectId, Integer targetId, String positions) throws ForbiddenException {
         int accessLevel = getProjectAccessLevel(token, projectId);
-        int targetLevel = getProjectAccessLevel(targetId, 2, projectId);  //假定目标的全局level为2，防止get时出现问题
+        int originTargetLevel = getProjectAccessLevelIgnoreGlobalLevel(targetId,  projectId);
+        int targetLevel = 3;
 
         if (accessLevel == 0) {
             throw new ForbiddenException(IProjectGroupService.UNABLE_TO_ACCESS_PROJECT);
         }
-        if (accessLevel > 2 || accessLevel >= targetLevel) {
+        if (accessLevel > 2 || accessLevel >= originTargetLevel) {
             throw new ForbiddenException(ForbiddenException.UNABLE_TO_OPERATE);
         }
         String[] positionArray = positions.split(",");
diff --git a/src/main/java/cn/edu/hfut/rmdjzz/projectmanagement/service/impl/TaskServiceImpl.java b/src/main/java/cn/edu/hfut/rmdjzz/projectmanagement/service/impl/TaskServiceImpl.java
index 35f3b41..48f65b1 100644
--- a/src/main/java/cn/edu/hfut/rmdjzz/projectmanagement/service/impl/TaskServiceImpl.java
+++ b/src/main/java/cn/edu/hfut/rmdjzz/projectmanagement/service/impl/TaskServiceImpl.java
@@ -45,7 +45,10 @@ public class TaskServiceImpl extends ServiceImpl<TaskMapper, Task> implements IT
         if (fatherId == null) {
             throw new BadRequestException(BadRequestException.WRONG_PARAMETERS);
         }
-        return baseMapper.selectSubTaskList(projectId, fatherId);
+        return baseMapper.selectTaskList(Wrappers.<Task>lambdaQuery()
+                .eq(Task::getTaskProjectId, projectId)
+                .eq(Task::getTaskFatherId, fatherId)
+                .eq(Task::getDeleted, false));
     }
 
     @Override
@@ -132,7 +135,7 @@ public class TaskServiceImpl extends ServiceImpl<TaskMapper, Task> implements IT
 
     @Override
     public List<StaffProcessDTO> getProjectStatistics(String token, Integer projectId, Integer staffId) throws ForbiddenException {
-        if(staffId != null && !TokenUtils.getStaffId(token).equals(staffId)) {
+        if (staffId != null && !TokenUtils.getStaffId(token).equals(staffId)) {
             throw new ForbiddenException(IProjectGroupService.UNABLE_TO_ACCESS_PROJECT);
         }
         if (projectGroupService.getProjectAccessLevel(token, projectId) == 0) {
@@ -519,13 +522,13 @@ public class TaskServiceImpl extends ServiceImpl<TaskMapper, Task> implements IT
     }
 
     @Override
-    public Map<String, Long> getProjectProcessOfEveryone(String token, Integer projectId) throws ForbiddenException{
-        if(projectGroupService.getProjectAccessLevel(token, projectId) == 0) {
+    public Map<String, Long> getProjectProcessOfEveryone(String token, Integer projectId) throws ForbiddenException {
+        if (projectGroupService.getProjectAccessLevel(token, projectId) == 0) {
             throw new ForbiddenException(IProjectGroupService.UNABLE_TO_ACCESS_PROJECT);
         }
         Map<String, Long> resMap = new HashMap<>();
         List<TaskNumOfEveryoneDTO> resList = baseMapper.selectProjectProcessOfEveryone(projectId);
-        for(TaskNumOfEveryoneDTO taskNumOfEveryoneDTO: resList) {
+        for (TaskNumOfEveryoneDTO taskNumOfEveryoneDTO : resList) {
             resMap.put(taskNumOfEveryoneDTO.getStaffFullname(), taskNumOfEveryoneDTO.getCompletedNum());
         }
         return resMap;
diff --git a/src/main/resources/mapper/TaskMapper.xml b/src/main/resources/mapper/TaskMapper.xml
index 9686caa..4920d12 100644
--- a/src/main/resources/mapper/TaskMapper.xml
+++ b/src/main/resources/mapper/TaskMapper.xml
@@ -27,29 +27,6 @@
                  JOIN (SELECT staff_id, staff_fullname FROM staff) AS s ON t.task_holder_id = s.staff_id
             ${ew.customSqlSegment}
     </select>
-    <select id="selectSubTaskList" resultMap="taskDto">
-        SELECT task_id,
-               task_name,
-               task_project_id,
-               task_holder_id,
-               s.staff_fullname AS task_holder_name,
-               task_status,
-               task_type,
-               t.task_father_id,
-               task_created_time,
-               task_start_time,
-               task_end_time,
-               task_closed_time,
-               task_priority,
-               task_description,
-               attached_info,
-               children_count
-        FROM task AS t
-                 JOIN (SELECT staff_id, staff_fullname FROM staff) AS s ON t.task_holder_id = s.staff_id
-        WHERE is_deleted = 0
-          AND task_project_id = #{projectId}
-          AND t.task_father_id = #{fatherId}
-    </select>
     <select id="selectProjectProcess"
             resultType="cn.edu.hfut.rmdjzz.projectmanagement.entity.dto.StaffProcessDTO">
         SELECT task_type,